I'm having a bit of time trying to follow that block of code... your formatting is awful How about indenting blocks of code with a couple spaces or a tab instead?
You may want to:
-make sure the page number passed in is valid
-chomp() @data as it's being read in, then use $#data + 1 to get the number of saved links instead of that nasty foreach loop
-make the number of links per page a variable
-make the current page non-linked in the page span section.
This doesn't make a whole lot of sense:
next if ($data[$count] !~ /\d+/);because when will $count not be a series of digits? But if it isn't, the count is still incremented and you will NOT get 5 links on the page.
I hope you find this as positive constructive critizicism and nothing else.
--Drew
Free, hot camel soup for Links hackers...
http://www.camelsoup.com
You may want to:
-make sure the page number passed in is valid
-chomp() @data as it's being read in, then use $#data + 1 to get the number of saved links instead of that nasty foreach loop
-make the number of links per page a variable
-make the current page non-linked in the page span section.
This doesn't make a whole lot of sense:
Code:
while ($count++ < 5) { next if ($data[$count] !~ /\d+/);
I hope you find this as positive constructive critizicism and nothing else.
--Drew
Free, hot camel soup for Links hackers...
http://www.camelsoup.com