Gossamer Forum: Products: Gossamer Links: Development, Plugins and Globals: [NEW PLUGIN] RNotifier

Veteran / Moderator (18441 posts)

Dec 9, 2005, 3:37 AM

Post #1 of 39

Shortcut

[NEW PLUGIN] RNotifier

Hi,

I'm pleased to announce the release of RNotifier

Price: $75
Details: http://www.ultranerds.com/...bin/details/163.html

Description: This plugin will send out an email to users who have posted a review on a link previously (for example, person A makes a review, which is added.. and then person B also makes a review; Person A is then notified of this new review [assuming they have this option turned on in their profile]).

For an example of how this is being used, and *why* to use it, please see this thread =) http://www.gossamer-threads.com/...i?post=287252#287252

This plugin is also part of the ULTRA Package Pro.

If you have any questions, please don't hesitate to ask.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Dec 9, 2005, 9:37 PM

Dinky

User (354 posts)

Dec 9, 2005, 9:37 PM

Post #2 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Andy,
Nice squirrel...

Laugh

</not a clue>

Dec 11, 2005, 3:22 PM

aus_dave

User (276 posts)

Dec 11, 2005, 3:22 PM

Post #3 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Looks good Andy :).

I noticed on the Ultranerds site that require validation for reviews needs to be on. Is there any way to modify this plug-in if I am using auto-validate reviews for registered users?

Dec 12, 2005, 1:04 AM

Veteran / Moderator (18441 posts)

Dec 12, 2005, 1:04 AM

Post #4 of 39

Shortcut

Re: [aus_dave] [NEW PLUGIN] RNotifier In reply to

Hi,

I'll have a look at that later =) I did start working on something like that, but then decided against it.

I may just release a seperate version, as it got pretty cluttered trying to accomidate for both types (validated, and non validated).

Cheers

Andy (mod)
andy@ultranerds.co.uk

Apr 22, 2006, 8:30 PM

katabd

Veteran (1187 posts)

Apr 22, 2006, 8:30 PM

Post #5 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hello Andy

We installed this plug in today and set it up..

When we tested it we never got any emails in both cases were we should have had.

Any ideas on this or does anyone else have this?
Regards
KaTaBd

Users plug In - Multi Search And Remote Search plug in - WebRing plug in - Muslims Directory

Apr 28, 2006, 1:04 PM

katabd

Veteran (1187 posts)

Apr 28, 2006, 1:04 PM

Post #6 of 39

Shortcut

Re: [katabd] [NEW PLUGIN] RNotifier In reply to

ANyone else using this plug in and having this issue?
Regards
KaTaBd

Users plug In - Multi Search And Remote Search plug in - WebRing plug in - Muslims Directory

May 21, 2006, 4:05 PM

katabd

Veteran (1187 posts)

May 21, 2006, 4:05 PM

Post #7 of 39

Shortcut

Re: [katabd] [NEW PLUGIN] RNotifier In reply to

Has anyone had this issue resolved or figured out please?
Regards
KaTaBd

Users plug In - Multi Search And Remote Search plug in - WebRing plug in - Muslims Directory

Oct 29, 2008, 6:47 AM

Enthusiast (893 posts)

Oct 29, 2008, 6:47 AM

Post #8 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
I just realized, that Rnotifier sends out more than one notification when I validate reviews 2 or 3 times a day.

For Example:
Validating review for User A at 10.00 am
User A gets an email, cause there is a review on his link

Validating review for User B at 11.00 am
User B gets an email, cause there is a review on his link
User A gets his email again?

Do you know how to stop this?
Thanks

Matthias
gpaed.de

Oct 29, 2008, 6:51 AM

Veteran / Moderator (18441 posts)

Oct 29, 2008, 6:51 AM

Post #9 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

Mmm... not off the top of my head. I guess it would need some kinda tracking, to see if an email has already been sent. Bit busy with jobs today, but will try and have a look at it for you at some point Smile

Cheers

Andy (mod)
andy@ultranerds.co.uk

Oct 29, 2008, 7:02 AM

Enthusiast (893 posts)

Oct 29, 2008, 7:02 AM

Post #10 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

There is no need to hurry Wink

Matthias
gpaed.de

Nov 4, 2008, 7:06 AM

Enthusiast (893 posts)

Nov 4, 2008, 7:06 AM

Post #11 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
dont know if I got the problem really.
I just validated 5 reviews. Rnotifier should have notified me on only one of this 5 reviews.
Rnotifier notified me on one of this 5 reviews, but the plugin sent me this 5 identical notifications!!!

Thanks

Matthias
gpaed.de

Nov 4, 2008, 7:14 AM

Veteran / Moderator (18441 posts)

Nov 4, 2008, 7:14 AM

Post #12 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

Right, were these reviews made by you, or other users?

I may end up just re-writing that plugin - I believe its quite old (like a few years old =)), and I've learned a lot of new tricks in that time :)

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 4, 2008, 7:16 AM

Enthusiast (893 posts)

Nov 4, 2008, 7:16 AM

Post #13 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

These Reviews were from other users...

Matthias
gpaed.de

Nov 4, 2008, 7:27 AM

Veteran / Moderator (18441 posts)

Nov 4, 2008, 7:27 AM

Post #14 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Mmm.. I'll have a play around, and see what I can find. Pretty busy still =)

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 18, 2008, 12:50 PM

Enthusiast (893 posts)

Nov 18, 2008, 12:50 PM

Post #15 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
I still have problems with the Rnotifier Wink

Matthias

Matthias
gpaed.de

Nov 18, 2008, 11:59 PM

Veteran / Moderator (18441 posts)

Nov 18, 2008, 11:59 PM

Post #16 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

I'll try and have a look today. No promises though <G>

Just to re-itterate - the problem is, that people are getting sent multiple notifications to a review, even if they h ave already just been sent a notification for the same review?

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 19, 2008, 12:04 AM

Enthusiast (893 posts)

Nov 19, 2008, 12:04 AM

Post #17 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Andy wrote:

people are getting sent multiple notifications to a review, even if they h ave already just been sent a notification for the same review?

Yes, that's right
Matthias

Matthias
gpaed.de

Nov 19, 2008, 12:22 AM

Veteran / Moderator (18441 posts)

Nov 19, 2008, 12:22 AM

Post #18 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Ok, will see what I can do later today.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 29, 2008, 1:41 AM

Enthusiast (893 posts)

Nov 29, 2008, 1:41 AM

Post #19 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Andy wrote:

Ok, will see what I can do later today.

Cheers

Hi Andy, did you find the error?

Matthias
gpaed.de

Nov 30, 2008, 12:46 AM

Veteran / Moderator (18441 posts)

Nov 30, 2008, 12:46 AM

Post #20 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

Sorry, got sidetracked again :( Please remind me on monday (via email), and I'll try to take a look. Been one hell of a week ;)

Cheers

Andy (mod)
andy@ultranerds.co.uk

Feb 28, 2010, 10:11 AM

Enthusiast (893 posts)

Feb 28, 2010, 10:11 AM

Post #21 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
just had this problem again and I think I have so additonal information that can help to solve this problem.

I validated three Reviews and there was on review that replied to a link, which I have already posted a review on.
I got the review that replied to my review three times.

Perhaps it has to do something with the number of reviews I am validating?

Matthias
gpaed.de

Mar 1, 2010, 12:43 AM

Veteran / Moderator (18441 posts)

Mar 1, 2010, 12:43 AM

Post #22 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

Will try and take a look at this for ya today at some point (time permitting)

Cheers

Andy (mod)
andy@ultranerds.co.uk

Mar 6, 2010, 6:14 AM

Veteran / Moderator (18441 posts)

Mar 6, 2010, 6:14 AM

Post #23 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

I'm just installing this plugin now, and will try and reproduce it. Still not 100% sure how it can be done (I don't think the number of reviews would have anything to do with it, but its worth investigating)

Cheers

Andy

Andy (mod)
andy@ultranerds.co.uk

Mar 6, 2010, 6:51 AM

Veteran / Moderator (18441 posts)

Mar 6, 2010, 6:51 AM

Post #24 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Ok,well I've finally replicated the problem.

I added a review, then added another 2 review (from different users, on the same link). Then, when I validated the link - it sent out a ton of emails (which it shouldn't do)

Now just to try and track the problem down huh?

Cheers

Andy (mod)
andy@ultranerds.co.uk

Mar 6, 2010, 6:58 AM

Veteran / Moderator (18441 posts)

Mar 6, 2010, 6:58 AM

Post #25 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Eugh, this is REALLY pissing me off :/

I think I may just re-write this plugin (it was written 4 years ago, so is in need of a rewrite really :p)

Will see what I can come up with.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Mar 6, 2010, 7:13 AM

Veteran / Moderator (18441 posts)

Mar 6, 2010, 7:13 AM

Post #26 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

NOW this is interesting!

It looks like this hook gets called 3 times!

Code:
		'hooks' => [ 
			[ 
				'validate_review', 
				'POST', 
				'Plugins::RNotifier::add_review', 
				'1' 
			] 
		],

I add this code in:

Code:
sub add_review { 

    my @args = @_; 

    print $IN->header if $DEBUG > 0; 

    my $args = $IN->get_hash(); 
    my @ids; 
    while (my ($key, $param) = each %$args) { 
      if ($key =~ /^(\d+)-ReviewID/) { 
          push @ids, $1; 
      } 
    } 


#tools_validate_reviews.html 
	print "FOO: " . $IN->param('do') . "<br />";

..and it prints out the following:

Code:
FOO: page 
FOO: page 
FOO: page

Very weird! Gonna email GT, to see if this is a bug they have fixed up (or are unaware of)

Will let you know once I hear something back.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Mar 6, 2010, 8:03 AM

Enthusiast (893 posts)

Mar 6, 2010, 8:03 AM

Post #27 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

I'm glad that you found the problem. Just thought it's only my problem Frown

Matthias
gpaed.de

Mar 6, 2010, 8:06 AM

Veteran / Moderator (18441 posts)

Mar 6, 2010, 8:06 AM

Post #28 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Yeah

I'm wondering if its maybe due to being the wrong hook (although not sure what the right one would be) ... as I think when someone "adds" (or a review is validated), that review_add hook gets called - could be wrong though.

Will keep you posted once I hear back from GT

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 23, 2010, 8:20 AM

Enthusiast (893 posts)

Nov 23, 2010, 8:20 AM

Post #29 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
do you have any updates on this problem?
My user are posting more and more reviews and I have still this problem?

Thanks

Matthias
gpaed.de

Nov 23, 2010, 8:25 AM

Veteran / Moderator (18441 posts)

Nov 23, 2010, 8:25 AM

Post #30 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

The only way I've managed to come up with since then, is to add a new field to the "Reviews" table called ReviewEmailBeenSent = 1/0

Then, when the review has been procesed, we set it to 1, and then have some code that stops it being run again

However, this was on a modified version - so dont think that would work on your install :(

Would be nice if GT could come up with a specific hook, for the "overall" review validation system , instead of just 1 that gets run for every single review (i.e you validate 6 reviews, and it gets run 6 times :()

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 23, 2010, 9:30 AM

Enthusiast (893 posts)

Nov 23, 2010, 9:30 AM

Post #31 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hi Andy,
I thought Adrian posted already a fix for this.
I was waiting for a GT Links Update and now I even can't find the fix anymore...

Matthias
gpaed.de

Nov 23, 2010, 9:34 AM

Veteran / Moderator (18441 posts)

Nov 23, 2010, 9:34 AM

Post #32 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Hi,

If you find it, let me know - and I'll have another look (pretty busy atm, so not sure when I will have time to look at it :()

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 23, 2010, 3:39 PM

Staff (4101 posts)

Nov 23, 2010, 3:39 PM

Post #33 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Andy wrote:

NOW this is interesting!

It looks like this hook gets called 3 times!

Code:
		'hooks' => [ 
			[ 
				'validate_review', 
				'POST', 
				'Plugins::RNotifier::add_review', 
				'1' 
			] 
		],

Why is this weird? The validate_review hook is used for both the admin as well as the browser interfaces, where one validates multiple reviews and the other validates a single review. The hook is supposed to run for each review, not once for all reviews.

Adrian

Nov 23, 2010, 3:40 PM

Staff (4101 posts)

Nov 23, 2010, 3:40 PM

Post #34 of 39

Shortcut

Re: [Matthias70] [NEW PLUGIN] RNotifier In reply to

Matthias70 wrote:

Hi Andy,
I thought Adrian posted already a fix for this.
I was waiting for a GT Links Update and now I even can't find the fix anymore...

I looked through the recent commits and don't see anything. I also don't recall looking into this issue before.

Adrian

Nov 23, 2010, 11:32 PM

Veteran / Moderator (18441 posts)

Nov 23, 2010, 11:32 PM

Post #35 of 39

Shortcut

Re: [brewt] [NEW PLUGIN] RNotifier In reply to

Right ok, so how exactly are you meant to get the values from that hook?

Cos I just changed that function to:

Code:
sub add_review { 

    my @args = @_; 

	use Data::Dumper; 
	print $IN->header; 
	print Dumper(@_) . "\n\n\n\n";; 


	return @_; 

}

..and then validated 2 reviews - yet nothing was outputted.

If its run every single time a review is validated, there must be a way to grab the data? Wink

TIA

Andy (mod)
andy@ultranerds.co.uk

Nov 24, 2010, 3:47 AM

Staff (4101 posts)

Nov 24, 2010, 3:47 AM

Post #36 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Well, just like any POST hook, you only get the return of the function as input to your hooked function. For validate_review, it doesn't actually return anything, so you get undef. Either you parse $IN for the info you need (won't work in this situation), or you set up a PRE hook to grab the input you need.

Adrian

Nov 24, 2010, 3:52 AM

Veteran / Moderator (18441 posts)

Nov 24, 2010, 3:52 AM

Post #37 of 39

Shortcut

Re: [brewt] [NEW PLUGIN] RNotifier In reply to

Ah ok - so using a PRE hook should pass in the data from JUST 1 review? (and then it gets run every review that is validated/rejected) .. or am I mis-understanding?

Cheers

Andy (mod)
andy@ultranerds.co.uk

Nov 24, 2010, 10:53 AM

Enthusiast (893 posts)

Nov 24, 2010, 10:53 AM

Post #38 of 39

Shortcut

Re: [Andy] [NEW PLUGIN] RNotifier In reply to

Hm, I don't understand what you are talking about Whistle

but it sounds, that you are close to a solution...

Matthias
gpaed.de

Nov 24, 2010, 3:17 PM